Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TorrentGalaxyBridge] Add new bridge #1378

Merged
merged 3 commits into from
Dec 2, 2019
Merged

[TorrentGalaxyBridge] Add new bridge #1378

merged 3 commits into from
Dec 2, 2019

Conversation

GregThib
Copy link
Contributor

@GregThib GregThib commented Dec 1, 2019

New bridge for TorrentGalaxy. This bridge provide a feed for TGx based on search term and the required language.
TorrentGalaxy shares MiNX releases (x265 encoded videos), lighter in size and with a better resolution.

Known-bug: sometimes the site ask for a a human validation, but this occur not so often.

@GregThib
Copy link
Contributor Author

GregThib commented Dec 1, 2019

Hmmm, Travis annoyed me with "String concat is not required here; use a single string instead" where I use something like $var = self::URI . '/torrents.php'
Should I correct that ? Because it's seems very legit to write that kind of statement. "self::URI/torrents.php" is not very conventional, nor easily readable.
Someone to tell me the best way ?

@logmanoriginal
Copy link
Contributor

Travis is actually complaining about the entire statement up to the final semi-colon. It just happens to begin at that line. Essentially, if you concatenate two literal strings, you can just make them one. There is an example on the Wiki.

@logmanoriginal
Copy link
Contributor

Looks good to me. Thanks for your contribution 👍

@logmanoriginal logmanoriginal merged commit 595b879 into RSS-Bridge:master Dec 2, 2019
@GregThib GregThib deleted the devel-tgx branch December 19, 2019 16:31
infominer33 pushed a commit to web-work-tools/rss-bridge that referenced this pull request Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants